Misc fixes - #19
Merged
Arctis-Fireblight merged 19 commits intoJun 27, 2026
Merged
Conversation
Contributor
|
Warning Review limit reached
More reviews will be available in 37 minutes and 23 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds a version-aware documentation viewer with heading IDs and a TOC sidebar, updates version and slug handling, revises documentation links and content, and adds test and repository support files. ChangesDocumentation viewer and rendering
Docs content, tests, and repo support
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Redot-Documentation/docs/26.1/pudding.md`:
- Around line 1-2: Replace the placeholder content in the pudding.md file with
actual documentation content for Redot version 26.1 features, or remove the file
entirely if it was created for testing purposes only. The current content
starting with "I LIKE CHOCOLATE MILK!!!!!" must be replaced with professionally
written documentation that follows the documentation style standards, including
removing the excessive exclamation marks and ensuring all content is appropriate
for production use.
In `@Redot-Documentation/docs/Community/tutorials.md`:
- Line 21: In the sentence describing GDQuest's Learn GDScript From Zero
tutorial, apply hyphenation to the compound adjective modifying "interactive
tutorial". Change "free and open source" to "free and open-source" since
compound adjectives that appear before a noun should be hyphenated for proper
grammar.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ed683eda-8264-4a2a-92da-351f71911386
📒 Files selected for processing (13)
.gitignoreRedot-Documentation.slnRedot-Documentation/Components/Layout/NavMenu.razorRedot-Documentation/Components/Layout/NavSectionTree.razorRedot-Documentation/Services/VersionManagerService.csRedot-Documentation/docs/26.1/pudding.mdRedot-Documentation/docs/About/complying_with_licenses.mdRedot-Documentation/docs/About/docs_changelog.mdRedot-Documentation/docs/About/introduction.mdRedot-Documentation/docs/About/list_of_features.mdRedot-Documentation/docs/About/system_requirements.mdRedot-Documentation/docs/Community/tutorials.mdRedot-Documentation/docs/Versions.json
💤 Files with no reviewable changes (4)
- Redot-Documentation/docs/About/complying_with_licenses.md
- Redot-Documentation/docs/About/list_of_features.md
- Redot-Documentation/docs/About/introduction.md
- Redot-Documentation/docs/About/docs_changelog.md
…tiveServer so that its state persists and updates properly
Arctis-Fireblight
force-pushed
the
misc-fixes
branch
from
June 22, 2026 17:40
ed34096 to
10eb622
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Redot-Documentation/docs/Community/tutorials.md (1)
21-21: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winApply hyphenation to compound adjective.
Line 21 uses "free and open source" to modify "interactive tutorial", but compound adjectives before a noun should be hyphenated: "free and open-source interactive tutorial". This issue was flagged in a previous review and remains unfixed.
✏️ Proposed fix
-GDQuest's *Learn GDScript From Zero* is a free and open source interactive tutorial for absolute beginners to learn to program with Redot's GDScript language. It is available as a [desktop application](https://gdquest.itch.io/learn-godot-gdscript) or [in the browser](https://gdquest.github.io/learn-gdscript). +GDQuest's *Learn GDScript From Zero* is a free and open-source interactive tutorial for absolute beginners to learn to program with Redot's GDScript language. It is available as a [desktop application](https://gdquest.itch.io/learn-godot-gdscript) or [in the browser](https://gdquest.github.io/learn-gdscript).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Redot-Documentation/docs/Community/tutorials.md` at line 21, In the tutorials.md file, locate the phrase describing GDQuest's tutorial on line 21 that contains "free and open source interactive tutorial". Apply hyphenation to the compound adjective by changing "open source" to "open-source" so that the phrase reads "free and open-source interactive tutorial". Compound adjectives modifying a noun should be hyphenated to follow proper English grammar conventions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Redot-Documentation/docs/Community/tutorials.md`:
- Around line 19-21: The text describing the GDQuest Learn GDScript From Zero
tutorial incorrectly states "Redot's GDScript language" which misrepresents the
resource as being for Redot when it was designed for Godot Engine. In the
description around line 21, either rephrase to clarify that this is a Godot
resource (e.g., "learn to program with GDScript for Godot Engine"), or remove
the mention of Redot entirely and rely on the callout disclaimer that already
correctly identifies such resources as targeting Godot. Ensure the inline
description no longer implies Redot authorship or sponsorship of the tutorial.
---
Nitpick comments:
In `@Redot-Documentation/docs/Community/tutorials.md`:
- Line 21: In the tutorials.md file, locate the phrase describing GDQuest's
tutorial on line 21 that contains "free and open source interactive tutorial".
Apply hyphenation to the compound adjective by changing "open source" to
"open-source" so that the phrase reads "free and open-source interactive
tutorial". Compound adjectives modifying a noun should be hyphenated to follow
proper English grammar conventions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c1456afc-271e-4b10-9e82-e04c1c2a82ce
📒 Files selected for processing (13)
.gitignoreRedot-Documentation.slnRedot-Documentation/Components/Layout/NavMenu.razorRedot-Documentation/Components/Layout/NavSectionTree.razorRedot-Documentation/Services/VersionManagerService.csRedot-Documentation/docs/26.1/pudding.mdRedot-Documentation/docs/About/complying_with_licenses.mdRedot-Documentation/docs/About/docs_changelog.mdRedot-Documentation/docs/About/introduction.mdRedot-Documentation/docs/About/list_of_features.mdRedot-Documentation/docs/About/system_requirements.mdRedot-Documentation/docs/Community/tutorials.mdRedot-Documentation/docs/Versions.json
💤 Files with no reviewable changes (4)
- Redot-Documentation/docs/About/docs_changelog.md
- Redot-Documentation/docs/About/complying_with_licenses.md
- Redot-Documentation/docs/About/list_of_features.md
- Redot-Documentation/docs/About/introduction.md
✅ Files skipped from review due to trivial changes (5)
- Redot-Documentation/docs/About/system_requirements.md
- Redot-Documentation/docs/Versions.json
- Redot-Documentation.sln
- .gitignore
- Redot-Documentation/Components/Layout/NavSectionTree.razor
🚧 Files skipped from review as they are similar to previous changes (2)
- Redot-Documentation/Components/Layout/NavMenu.razor
- Redot-Documentation/Services/VersionManagerService.cs
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Redot-Documentation/wwwroot/app.css`:
- Around line 260-265: The `.doc-viewer-layout` grid always reserves the TOC
column even when `DocViewer` does not render `.doc-viewer-toc`, leaving empty
space for pages with no headings. Update the layout styling so the second track
collapses when the TOC is absent, using the existing `.doc-viewer-layout` and
`.doc-viewer-toc` selectors to make the right column conditional instead of
always fixed at 280px.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2c26deab-41a5-43af-94b8-3a5ef3c5f6fb
📒 Files selected for processing (3)
Redot-Documentation/Components/Pages/DocViewer.razorRedot-Documentation/Versioning/VersionProvider.csRedot-Documentation/wwwroot/app.css
✅ Files skipped from review due to trivial changes (1)
- Redot-Documentation/Versioning/VersionProvider.cs
…ders if it has content Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ixes, update documentation links, and streamline markdown rendering with version-aware logic.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
Redot-Documentation/docs/About/system_requirements.md (1)
29-29: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove trailing spaces inside link text.
Both modified lines have spaces before the closing
]. Fix while editing:-Support for Windows 7/8/8.1 may be removed in a -[future Redot 4.x release ](abt_release_policy). +Support for Windows 7/8/8.1 may be removed in a +[future Redot 4.x release](abt_release_policy).Also applies to: 104-104
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Redot-Documentation/docs/About/system_requirements.md` at line 29, The markdown link text for the abt_release_policy reference contains trailing spaces before the closing bracket, which should be removed. Update the affected link in the documentation so the visible text has no extra spaces before ] while keeping the same target and wording otherwise.Redot-Documentation/docs/About/faq.md (1)
477-479: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove trailing spaces inside link text.
The modified lines contain spaces before the closing
]which triggers MD039. Since these lines are already being edited, clean up the spacing:-This custom UI toolkit [can't be used as a library ](abt_faq_use_Redot_as_library), +This custom UI toolkit [can't be used as a library](abt_faq_use_Redot_as_library), but you can still -[use Redot to create non-game applications by using the editor ](abt_faq_non_game_applications). +[use Redot to create non-game applications by using the editor](abt_faq_non_game_applications).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Redot-Documentation/docs/About/faq.md` around lines 477 - 479, The link text in the FAQ markdown contains trailing spaces before the closing bracket, which triggers MD039. Clean up the spacing in the edited sentence in the faq.md content so the links around abt_faq_use_Redot_as_library and abt_faq_non_game_applications have no extra spaces inside the link text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Redot-Documentation/Components/Pages/DocViewer.razor`:
- Around line 114-118: The version-routing logic in DocViewer.razor accepts a
case-insensitive match via VersionManagerService.Versions.Contains, but then
looks up the provider using the original versionSegment, which can fail for
differently cased routes like /en/LATEST/.... Update the provider lookup in the
same conditional block to use the matched version key from
VersionManagerService.Versions (or another canonical key from
VersionManagerService) before calling GetVersionProvider, so the lookup and
guard stay consistent.
In `@Redot-Documentation/ExtensionMethods.cs`:
- Around line 10-12: CapitalizeEachWord currently indexes word[0] on every token
from Split(' '), so empty tokens from blank input or repeated spaces can throw
and break DocRendererService.TransformLink rendering. Update CapitalizeEachWord
to safely handle empty or whitespace-only tokens by skipping or preserving them
before accessing the first character, and make sure the TransformLink path still
produces a valid display name when labels contain consecutive spaces or
underscores converted to spaces.
- Around line 21-25: The StartsWithAny extension currently relies on the default
string prefix comparison, which can vary by culture and affect doc-link
rewriting. Update StartsWithAny in ExtensionMethods.cs to use ordinal prefix
matching via StringComparison.Ordinal for each prefix check against input,
keeping the behavior stable and locale-independent.
In `@Redot-Documentation/Services/DocRendererService.cs`:
- Around line 104-123: The link label normalization in DocRendererService should
only apply when the URL was rewritten from a slug. Update the link rendering
logic around the linkUrl/versionProvider.GetPathFromSlug path so the doc_ prefix
handling, underscore replacement, and trimming only run for slug-backed links,
while preserving authored labels unchanged for ordinary URLs and non-slug links.
---
Nitpick comments:
In `@Redot-Documentation/docs/About/faq.md`:
- Around line 477-479: The link text in the FAQ markdown contains trailing
spaces before the closing bracket, which triggers MD039. Clean up the spacing in
the edited sentence in the faq.md content so the links around
abt_faq_use_Redot_as_library and abt_faq_non_game_applications have no extra
spaces inside the link text.
In `@Redot-Documentation/docs/About/system_requirements.md`:
- Line 29: The markdown link text for the abt_release_policy reference contains
trailing spaces before the closing bracket, which should be removed. Update the
affected link in the documentation so the visible text has no extra spaces
before ] while keeping the same target and wording otherwise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b0e2c092-eb4e-4739-bd8b-e82d5c2429a5
📒 Files selected for processing (17)
Redot-Documentation-Tests/ExtensionMethodTests.csRedot-Documentation-Tests/Redot-Documentation-Tests.csprojRedot-Documentation.slnRedot-Documentation/Components/Pages/DocViewer.razorRedot-Documentation/ExtensionMethods.csRedot-Documentation/Services/DocRendererService.csRedot-Documentation/Services/VersionManagerService.csRedot-Documentation/Versioning/Article.csRedot-Documentation/Versioning/VersionProvider.csRedot-Documentation/docs/About/docs_changelog.mdRedot-Documentation/docs/About/faq.mdRedot-Documentation/docs/About/introduction.mdRedot-Documentation/docs/About/list_of_features.mdRedot-Documentation/docs/About/system_requirements.mdRedot-Documentation/docs/Community/asset_library/submitting_to_assetlib.mdRedot-Documentation/docs/Community/tutorials.mdRedot-Documentation/wwwroot/app.css
✅ Files skipped from review due to trivial changes (4)
- Redot-Documentation/docs/Community/asset_library/submitting_to_assetlib.md
- Redot-Documentation/docs/About/list_of_features.md
- Redot-Documentation.sln
- Redot-Documentation/docs/Community/tutorials.md
🚧 Files skipped from review as they are similar to previous changes (3)
- Redot-Documentation/docs/About/docs_changelog.md
- Redot-Documentation/docs/About/introduction.md
- Redot-Documentation/wwwroot/app.css
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…add corresponding test cases Replaced the LINQ implementation with a dedicated loop and string builder. Should ultimately be more performant and more consistent across use cases.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Redot-Documentation/ExtensionMethods.cs`:
- Around line 25-27: The generated label casing in ExtensionMethods should be
culture-invariant, since char.ToUpper(c) depends on the current locale and can
produce inconsistent results. Update the label-building logic in the relevant
method that appends characters after lastCharWhitespace to use
char.ToUpperInvariant(c) instead of char.ToUpper(c), keeping generated
documentation labels stable across cultures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a73198e-acc0-4ce9-ad62-b5db7b25304d
📒 Files selected for processing (5)
DockerfileRedot-Documentation-Tests/ExtensionMethodTests.csRedot-Documentation.slnRedot-Documentation/Components/Pages/DocViewer.razorRedot-Documentation/ExtensionMethods.cs
🚧 Files skipped from review as they are similar to previous changes (3)
- Redot-Documentation.sln
- Redot-Documentation-Tests/ExtensionMethodTests.cs
- Redot-Documentation/Components/Pages/DocViewer.razor
This was referenced Jun 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is still a bit of a preview, but I have fixed a number of issues.
Still a bit a of a WIP. I will work on a few more issues before merge.
Summary by CodeRabbit
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Refactor
Chores