Skip to content

Fix Assetlib with with godot version - #1148

Merged
Arctis-Fireblight merged 1 commit into
Redot-Engine:devfrom
decryptedchaos:assetlib-fix
Jan 6, 2026
Merged

Fix Assetlib with with godot version#1148
Arctis-Fireblight merged 1 commit into
Redot-Engine:devfrom
decryptedchaos:assetlib-fix

Conversation

@decryptedchaos

@decryptedchaos decryptedchaos commented Jan 5, 2026

Copy link
Copy Markdown
Member

Fixes Assetlib checking against the wrong version string

Summary by CodeRabbit

  • Bug Fixes
    • Improved Asset Library version detection to correctly identify your engine's patch release version, ensuring more accurate compatibility filtering and asset recommendations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 5, 2026

Copy link
Copy Markdown

Walkthrough

A version macro is replaced in the asset library search URL construction. The query parameter now uses GODOT_VERSION_BRANCH instead of REDOT_VERSION_BRANCH when communicating with the Asset Library API.

Changes

Cohort / File(s) Summary
Asset Library Version Macro
editor/asset_library/asset_library_editor_plugin.cpp
Replaced version macro in asset library API query parameter from REDOT_VERSION_BRANCH to GODOT_VERSION_BRANCH

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is partially related to the changeset. It mentions fixing Assetlib with godot version, which aligns with the PR objective, but lacks specificity about the actual change (switching from REDOT_VERSION_BRANCH to GODOT_VERSION_BRANCH macro).
✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Fix all issues with AI Agents 🤖
In @editor/asset_library/asset_library_editor_plugin.cpp:
- Line 1086: The code sends GODOT_VERSION_BRANCH in the API query (args +=
"&godot_version=" + String(GODOT_VERSION_BRANCH)) but the error message later
prints REDOT_VERSION_BRANCH, causing inconsistent displayed vs. used versions;
update the error message that references REDOT_VERSION_BRANCH to use
GODOT_VERSION_BRANCH instead (or vice versa if you intentionally want the API to
use REDOT_VERSION_BRANCH), ensuring both the API query and the displayed error
use the same version macro so users see the exact version used for filtering.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 377a20a and 34a40f6.

📒 Files selected for processing (1)
  • editor/asset_library/asset_library_editor_plugin.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: 🐧 Linux / Template w/ Mono, release (target=template_release)
  • GitHub Check: 🤖 Android / Template arm32 (target=template_release, arch=arm32)
  • GitHub Check: 🍎 macOS / Template (target=template_release)
  • GitHub Check: 🐧 Linux / Editor with ThreadSanitizer (target=editor, dev_build=yes, use_tsan=yes, use_llvm=yes, linker=lld)
  • GitHub Check: 🏁 Windows / Template w/ GCC (target=template_release, use_mingw=yes)
  • GitHub Check: 🏁 Windows / Template (target=template_release)
  • GitHub Check: 🐧 Linux / Template w/ Mono, debug (target=template_debug)
  • GitHub Check: 🏁 Windows / Editor (target=editor)
  • GitHub Check: 🐧 Linux / Editor w/ Mono (target=editor)
  • GitHub Check: 🐧 Linux / Minimal template (target=template_release, everything disabled)
  • GitHub Check: 🍏 iOS / Template (target=template_release)
  • GitHub Check: 🌐 Web / Template w/o threads (target=template_release, threads=no)
  • GitHub Check: 🍎 macOS / Editor (target=editor)
  • GitHub Check: 🌐 Web / Template w/ threads (target=template_release, threads=yes)
  • GitHub Check: 🤖 Android / Template arm64 (target=template_release, arch=arm64)

Comment thread editor/asset_library/asset_library_editor_plugin.cpp
@Arctis-Fireblight Arctis-Fireblight self-assigned this Jan 5, 2026
@Arctis-Fireblight Arctis-Fireblight added this to the Redot LTS 26.1 milestone Jan 5, 2026

@Arctis-Fireblight Arctis-Fireblight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Arctis-Fireblight
Arctis-Fireblight merged commit b770ba5 into Redot-Engine:dev Jan 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants