Skip to content

Security scheme fixes #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slinkydeveloper wants to merge 2 commits into from
Closed

Security scheme fixes #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bdb9da
Fixes https://github.com/RepreZen/KaiZen-OpenApi-Parser/issues/44
slinkydeveloper May 29, 2017
0e86d06
Fixes https://github.com/RepreZen/KaiZen-OpenApi-Parser/issues/50
slinkydeveloper Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions kaizen-openapi-parser/src/main/java/com/reprezen/kaizen/oasparser/val/NumericUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,16 @@ enum NumericType {
LONG(Long.class), //
SHORT(Short.class);

private static Map<Class<? extends Number>, NumericType> types = Maps.newHashMap();
private static Map<Class<? extends Number>, NumericType> types;

private NumericType(Class<? extends Number> cls) {
register(cls, this);
}

private void register(Class<? extends Number> cls, NumericType type) {
types.put(cls, type);
if (NumericType.types == null)
NumericType.types = Maps.newHashMap();
types.put(cls, type);
}

public static NumericType of(Object value) {
Expand Down
24 changes: 16 additions & 8 deletions ...napi-parser/src/main/java/com/reprezen/kaizen/oasparser/val3/SecuritySchemeValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,22 @@ public class SecuritySchemeValidator extends ObjectValidatorBase<SecurityScheme>
public void validateObject(SecurityScheme securityScheme, ValidationResults results) {
// no validation for: description, bearerFormat
validateString(securityScheme.getType(), results, true, "apiKey|http|oauth2|openIdConnect", "type");
validateString(securityScheme.getName(), results, true, "name");
validateString(securityScheme.getIn(), results, true, "query|header", "in");
// TODO Q: Spec says 'flow' is required, but it's just a map of OAuthFlow objects, none of which is noted as
// required. What's the real requirement here? Is anything required if type != oauth2
validateField(securityScheme.getImplicitOAuthFlow(), results, false, "flow.implicit", oauthFlowValidator);
validateExtensions(securityScheme.getOAuthFlowsExtensions(), results, "flow");
// TODO Q: is this really required if type != openIdConnect?
validateUrl(securityScheme.getOpenIdConnectUrl(), results, true, "openIdConnectUrl");
switch (securityScheme.getType()) {
case "http":
// If bearer validate bearerFormat
break;
case "apiKey":
validateString(securityScheme.getName(), results, true, "name");
validateString(securityScheme.getIn(), results, true, "query|header", "in");
break;
case "oauth2":
validateField(securityScheme.getImplicitOAuthFlow(), results, false, "flow.implicit", oauthFlowValidator);
validateExtensions(securityScheme.getOAuthFlowsExtensions(), results, "flow");
break;
case "openIdConnect":
validateUrl(securityScheme.getOpenIdConnectUrl(), results, true, "openIdConnectUrl");
break;
}
validateExtensions(securityScheme.getExtensions(), results);
}

Expand Down