Skip to content

fix: husky pre-commit warning#93

Merged
MantisClone merged 1 commit into
mainfrom
fix-pre-commit
Feb 25, 2025
Merged

fix: husky pre-commit warning#93
MantisClone merged 1 commit into
mainfrom
fix-pre-commit

Conversation

@MantisClone
Copy link
Copy Markdown
Contributor

@MantisClone MantisClone commented Feb 25, 2025

Problem

Committing throws this warning:

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

Solution

  • Remove deprecated lines from .husky/pre-commit

Summary by CodeRabbit

  • Chores
    • Streamlined the pre-commit validation process to enhance code quality checks before commits.

```
husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0
```
@MantisClone MantisClone self-assigned this Feb 25, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 25, 2025

Walkthrough

The pull request modifies the Husky pre-commit hook by removing two lines from the .husky/pre-commit file. The removed lines include the shebang (#!/usr/bin/env sh) and the command that sources the Husky script. As a result, the hook now only runs the npx lint-staged command when a commit is attempted.

Changes

File Change Summary
.husky/pre-commit Removed the shebang and the command to source Husky’s script; now only executes npx lint-staged.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant Git as Git
    participant Pre as .husky/pre-commit
    participant Lint as npx lint-staged

    Dev->>Git: Commit changes
    Git->>Pre: Trigger pre-commit hook
    Pre->>Lint: Execute lint-staged
    Lint-->>Pre: Return lint results
    Pre-->>Git: Allow commit if linting passes
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86ee305 and 64c880e.

📒 Files selected for processing (1)
  • .husky/pre-commit (0 hunks)
💤 Files with no reviewable changes (1)
  • .husky/pre-commit

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MantisClone MantisClone merged commit 9013f63 into main Feb 25, 2025
@MantisClone MantisClone deleted the fix-pre-commit branch February 25, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants