Fix flag error display when duplicate flagging#466
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
yattias
approved these changes
Oct 21, 2025
saimuren
added a commit
to saimuren/web
that referenced
this pull request
Feb 17, 2026
Adds a menu item to upload figures to papers, implementing ResearchHub#466. Uses existing ImageUploadModal component.
saimuren
added a commit
to saimuren/web
that referenced
this pull request
Feb 17, 2026
Adds a menu item to upload figures to papers, implementing ResearchHub#466. Uses existing ImageUploadModal component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
useFlagging.ts was trying to JSON.parse() the error message string, which doesn't work because ApiError.message is just a plain string, not a JSON string. Additionally, it was looking for nested data objects that don't exist
Solution
Now it correctly accesses the errors property directly from the ApiError object, where the backend response data is actually stored.