Skip to content

Add RG353M/RG353V rumble support#63

Closed
r4df0x wants to merge 1 commit intoRetroGFX:mainfrom
r4df0x:main
Closed

Add RG353M/RG353V rumble support#63
r4df0x wants to merge 1 commit intoRetroGFX:mainfrom
r4df0x:main

Conversation

@r4df0x
Copy link
Copy Markdown

@r4df0x r4df0x commented Apr 11, 2026

Description

Adds a new RK3566-BSP kernel patch to enable native rumble support for the Anbernic RG353M and RG353V.

This ports the relevant pieces from the ArkOS RG353 kernel implementation:

  • adds PWM5 to the RG353M/RG353V singleadc-joypad device-tree nodes
  • registers standard Linux FF_RUMBLE support in singleadcjoy when a PWM is available
  • keeps rumble optional so devices without a pwms property should continue probing normally

Reference implementation:
christianhaitian/RG353VKernel@f82c197

This PR only adds one UnofficialOS build patch file:

projects/Rockchip/patches/linux/RK3566-BSP/0006-rg353-add-joypad-rumble.patch

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested Locally?

This has not been hardware tested on an RG353M/RG353V.

Local verification performed:

  • Confirmed the PR contains only one new file addition in the UnofficialOS tree
  • Checked that the new kernel patch targets the current RK3566-BSP kernel files from RetroGFX/rk356x-kernel
  • Checked the referenced kernel symbols/configs are present in the RK3566-BSP kernel source/config
  • Ran a GitHub Actions kernel-only build test in my fork
  • Applied this patch to the RK3566-BSP kernel source used by UnofficialOS
  • Configured the kernel with the UnofficialOS RK3566-BSP aarch64 kernel config
  • Compiled drivers/input/joystick/singleadcjoy.o
  • Compiled the RG353M and RG353V device trees

Build log:
https://github.com/r4df0x/UnofficialOS/actions/runs/24285058852/job/70912939712

Not performed:

  • Full UnofficialOS image build
  • RG353M/RG353V hardware test

Test Configuration:

  • Build OS name and version: GitHub Actions ubuntu-22.04
  • Docker (Y/N): N for the successful kernel-only test
  • UnofficialOS Branch: main
  • Any additional information that may be useful: The successful test was a kernel-only compile check, not a full UnofficialOS image build.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@r4df0x
Copy link
Copy Markdown
Author

r4df0x commented Apr 11, 2026

Update: I ran a GitHub Actions kernel-only build test in my fork for this patch.

The test:

  • cloned the RK3566-BSP kernel source used by UnofficialOS
  • applied this PR's 0006-rg353-add-joypad-rumble.patch
  • configured the kernel with the UnofficialOS RK3566-BSP aarch64 kernel config
  • compiled drivers/input/joystick/singleadcjoy.o
  • compiled the RG353M and RG353V device trees

Result: the test completed successfully.

Build log:
https://github.com/r4df0x/UnofficialOS/actions/runs/24285058852/job/70912939712

This is still not hardware tested on an RG353M/RG353V.

@r4df0x
Copy link
Copy Markdown
Author

r4df0x commented Apr 16, 2026

Turns out I can't really get the original implementation to work on dArkOS any more so this is pointless to continue.

@r4df0x r4df0x closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant