-
Notifications
You must be signed in to change notification settings - Fork 23
feat(PRO-547): bidirectional comment sync between the CLI and GitHub #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dastratakos
wants to merge
48
commits into
main
Choose a base branch
from
dean/pro-547-bidirectional-comment-sync-between-the-cli-and-github
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
2aaedec
feat(PRO-547): add CLI-side GitHub comment sync (pull/push)
dastratakos 74f2260
feat(PRO-547): add GitHub comment sync UI and author rendering
dastratakos 488e67c
feat(PRO-547): mirror PR resolved state on pull
dastratakos f7100d1
feat(PRO-547): sync comment resolution back to GitHub
dastratakos 5fce0b1
feat(PRO-547): add live GitHub review server layer (pending-review li…
dastratakos 4cf617e
feat(PRO-547): rebuild comment UI on live-fetch review model; remove …
dastratakos 89cad0a
chore(PRO-547): drop this PR's net-zero migrations (collapse into 0006)
dastratakos b1cba60
feat(PRO-547): add 'Comment on the PR' and 'Start a review' composer …
dastratakos 55e373c
feat(PRO-547): close review-tray fidelity gaps (pending list, markdow…
dastratakos 7a04c96
fix(PRO-547): address PR review — push guardrail, scope checks, atomi…
dastratakos 26f9a81
fix(PRO-547): guard unresolvable PR + discard empty review on failed …
dastratakos f438d7b
fix(PRO-547): preserve unposted replies on promote failure; guard rea…
dastratakos 59d37f8
fix(PRO-547): gate GitHub review on run diff == PR head; refresh PR q…
dastratakos 021301a
fix(PRO-547): guard submit/reply with assertPushable; scope PR-query …
dastratakos d9dd0c0
fix(PRO-547): keep string GraphQL vars as -f; serialize concurrent pr…
dastratakos 432d8e5
fix(PRO-547): reject empty Comment review at the API boundary
dastratakos 4d84878
fix(PRO-547): count pending drafts on anchorless threads to avoid fal…
dastratakos d049067
fix: restore GitHub comment sync and clarify destinations
dastratakos 0e3ee20
fix(PRO-547): harden pending review lifecycle
dastratakos 4217527
fix(PRO-547): address comment UI review feedback
dastratakos 90fd2b4
fix(PRO-547): harden review sync boundaries
dastratakos a9d2f97
fix(PRO-547): preserve review state across local edits
dastratakos 3a07ec7
fix(PRO-547): protect local thread promotion
dastratakos bacb789
fix(PRO-547): preserve pending review drafts
dastratakos 69e547d
fix(PRO-547): close review lifecycle races
dastratakos 3f123d8
refactor(PRO-547): encode review source invariants
dastratakos b5619c5
fix(PRO-547): sequence local review updates
dastratakos 8551312
fix(PRO-547): close review recovery gaps
dastratakos 8b91d66
fix(PRO-547): reconcile local review overlays
dastratakos 5b98fe0
fix(PRO-547): paginate review thread comments
dastratakos abcf6b3
fix(PRO-547): serialize review actions across processes
dastratakos 32c63fe
fix(PRO-547): harden review comment coordination
dastratakos bf0da95
fix(PRO-547): scope review locks by pull request
dastratakos 98f9749
fix(PRO-547): harden review state transitions
dastratakos e35195f
test: avoid server close port reuse race
dastratakos b98c5ca
fix(PRO-547): preserve comment destination choice
dastratakos 9a34627
fix(PRO-547): keep review state synchronized
dastratakos 934cb82
fix(PRO-547): honor checkout lock ordering
dastratakos 8f9c82a
fix(PRO-547): harden GitHub review writes
dastratakos ef39db9
fix(PRO-547): separate GitHub read deadlines
dastratakos e60e140
fix(PRO-547): respect read-only review state
dastratakos abc7def
fix(PRO-547): resume interrupted promotions
dastratakos 09f4196
fix(PRO-547): preserve unavailable PR states
dastratakos b9a700a
fix(PRO-547): preserve review state across transitions
dastratakos 023dafc
fix(PRO-547): harden review recovery controls
dastratakos 9181124
fix(PRO-547): close promotion mutation race
dastratakos 7ba804c
fix(PRO-547): bind review recovery to its origin
dastratakos d8cd3a4
fix(PRO-547): harden pending review edge cases
dastratakos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| DROP INDEX `comment_thread_scope_key_idx`;--> statement-breakpoint | ||
| ALTER TABLE `comment_thread` ADD `repoRoot` text NOT NULL DEFAULT '';--> statement-breakpoint | ||
| UPDATE `comment_thread` | ||
| SET `repoRoot` = COALESCE( | ||
| ( | ||
| SELECT MIN(`chapter_run`.`repoRoot`) | ||
| FROM `chapter_run` | ||
| WHERE `comment_thread`.`scopeKey` = CASE | ||
| WHEN `chapter_run`.`scopeKind` = 'committed' | ||
| THEN 'committed:' || `chapter_run`.`baseSha` || ':' || `chapter_run`.`headSha` || ':' || `chapter_run`.`mergeBaseSha` | ||
| ELSE 'workingTree:' || `chapter_run`.`workingTreeRef` || ':' || `chapter_run`.`baseSha` || ':' || `chapter_run`.`headSha` || ':' || `chapter_run`.`mergeBaseSha` | ||
| END | ||
| HAVING COUNT(DISTINCT `chapter_run`.`repoRoot`) = 1 | ||
| ), | ||
| `repoRoot` | ||
| );--> statement-breakpoint | ||
| CREATE INDEX `comment_thread_repo_scope_idx` ON `comment_thread` (`repoRoot`,`scopeKey`); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ALTER TABLE `comment_thread` ADD `promotionThreadNodeId` text;--> statement-breakpoint | ||
| ALTER TABLE `comment_thread` ADD `promotionRootCommentNodeId` text;--> statement-breakpoint | ||
| ALTER TABLE `comment_thread` ADD `promotionReplyCount` integer DEFAULT 0 NOT NULL; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.