RestApiHandler not returning a Rhubarb response object#22
Merged
Conversation
…reated from the Middleware layer
Contributor
|
@miscampbell the middleware response is returned before (line 149) the endpoint response is generated. Is your middleware registered correctly? |
…because any put request should specify the id to update in the url
| { | ||
| $resource = $this->get($params, $request); | ||
|
|
||
| if ($resource->id != $payload["id"]){ |
added 2 commits
January 30, 2019 16:47
…the body. Added Validation for an empty payload being sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the middleware layer was returning a valid response object but we were ignoring it and always returning a JsonResponse object. The example of the issue this fixes is on login the TokenAuthenticationMiddleware that validates your login was returning a TokenAuthorisationRequiredResponse object which we never returned.
The content of this response was not being adhered to and we were defaulting it to a standard JsonResponse object.