Skip to content

Replace StringBuilder.Replace with StringBuilder.Append for building request URL#4579

Merged
RicoSuter merged 1 commit intoRicoSuter:masterfrom
paulomorgado:remove-replace-from-url-generation
Nov 13, 2023
Merged

Replace StringBuilder.Replace with StringBuilder.Append for building request URL#4579
RicoSuter merged 1 commit intoRicoSuter:masterfrom
paulomorgado:remove-replace-from-url-generation

Conversation

@paulomorgado
Copy link
Contributor

This PR replaces the use of StringBuilder.Replace in the generation of the request URL with appending URL parts.

Before:

urlBuilder_.Append("sum/{a}/{b}");
urlBuilder_.Replace("{a}", System.Uri.EscapeDataString(ConvertToString(a, System.Globalization.CultureInfo.InvariantCulture)));
urlBuilder_.Replace("{b}", System.Uri.EscapeDataString(ConvertToString(b, System.Globalization.CultureInfo.InvariantCulture)));

After:

urlBuilder_.Append("sum");
urlBuilder_.Append('/');
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(a, System.Globalization.CultureInfo.InvariantCulture)));
urlBuilder_.Append('/');
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(b, System.Globalization.CultureInfo.InvariantCulture)));

This would be easier if the model for generation produced the different path parts already split and classified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants