Skip to content

Fix MDA shuffle under pandas copy-on-write #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamid-arian merged 1 commit into from
Jun 11, 2026
Merged

Fix MDA shuffle under pandas copy-on-write #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ Format: [Keep a Changelog](https://keepachangelog.com/en/1.1.0/); versioning: [S

## [Unreleased]

### Fixed
- `features.feature_importance` (MDA): feature shuffling mutated a column view
in place, which raises `ValueError: array is read-only` under pandas
copy-on-write (default since pandas 3.0). Now shuffles a copy and assigns back.

## [1.0.9]

### Fixed
Expand Down
7 changes: 6 additions & 1 deletion RiskLabAI/features/feature_importance/feature_importance_mda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ def compute(self, x: pd.DataFrame, y: pd.Series, **kwargs: Any) -> pd.DataFrame:
rng = np.random.default_rng(self.random_state + i)
for feature in x.columns:
x_test_shuffled = x_test.copy(deep=True)
rng.shuffle(x_test_shuffled[feature].values) # <-- USE SEEDED SHUFFLE
# Shuffle a copy and assign back: with pandas copy-on-write
# (default since pandas 3.0), column .values is a read-only
# view and in-place shuffling raises ValueError.
shuffled_values = x_test_shuffled[feature].to_numpy(copy=True)
rng.shuffle(shuffled_values) # seeded shuffle
x_test_shuffled[feature] = shuffled_values

shuffled_proba = fitted_classifier.predict_proba(x_test_shuffled)

Expand Down
Loading