DEV-123965 general improvements#98
Open
tomerparizer wants to merge 12 commits into
Open
Conversation
Introduce a coding-standard and static-analysis stack for the SDK: - phpcs (PSR-12) + PHPCompatibility targeting PHP 5.5+ via phpcs.xml.dist - phpstan level 5 with a baseline for pre-existing findings - composer scripts (lint/fix/analyse/check) and a CI workflow Fix the PHP 5.5 incompatibilities the tooling surfaced in Notification.php: replace the null-coalescing operators (PHP 7.0) and provide hash_equals (PHP 5.6) via symfony/polyfill-php56, plus a self-contained fallback polyfill loaded by the bundled autoloader for non-Composer consumers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop .github/workflows/ci.yml; CI is handled elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DavidRibeiroRiskified
changed the title
Contributor
Author
There was a problem hiding this comment.
yes.. i added the baseline and removed it in the next one
the idea is to merge _fixes into this branch
and then merge both
i just wanted to keep them separated since the linter touched all the files
| ================= | ||
| # Riskified PHP SDK | ||
|
|
||
| version: 1.12.0 |
Contributor
There was a problem hiding this comment.
Let's keep the v number in Readme
Contributor
Author
There was a problem hiding this comment.
we did.. we just moved it a little (to line 7)
DavidRibeiroRiskified
previously approved these changes
Jun 26, 2026
* DEV-123965 - fix composer analyze * DEV-123965 - fix composer lint * DEV-123965 - CR fixes
DavidRibeiroRiskified
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
Boost the repo with more standardization