Conversation
jvogt23
left a comment
jvogt23
left a comment
There was a problem hiding this comment.
Functionally appears to work well; can't be certain until test environment is fixed though, as I cannot check to be sure every attendance event is being tracked properly.
Mainly stylistic changes have been noted, will ask for second opinion. I also might have missed some things.
- Changed Buttons to RoundedButtons, removed commented code - Modified RoundedButton to take in a background color and a text color
jvogt23
left a comment
jvogt23
left a comment
There was a problem hiding this comment.
The changes I see look good; Nothing functional is affected by these changes so I will wait for the theme changes we discussed in the meeting to be added before I do another review and (hopefully) approve.
- Introduced component called ThemedText which is has the same usage as Text except adapts to dark/light mode - Side note: To get around linting flagging raw text in non-Text components, I had to use <Text> inside <ThemedText>, which may not be the best implementation - Refactored Attendance components slightly to make usage of SafeAreaView more efficient
|
I tried to implement dark mode using a new component called ThemedText which can be used the same as Text except the text adapts to theme colors. (This is because it would be inconvenient to keep passing currentTheme.onBackground to every text item.) The thing is, the linter was flagging any usage of raw text inside ThemedText, so I had to put a Text component inside some ThemedText components that used raw text. That feels a little inconvenient, but I didn't want to really change the linter either. |
2 participants
Implemented Attendance screen according to Kotlin app layout. Some notes:
Closes Implementation of Attendance #16