Handover Endpoint - Throw error when no agents are online#59
Merged
Conversation
Shailesh351
pushed a commit
to Shailesh351/Apps.Dialogflow
that referenced
this pull request
Jun 15, 2021
[Upstream Catchup] Merge RocketChat/Apps.Dialogflow:master to master
KevLehman
approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old behaviour:
If the handover fails and no agents were online, the endpoint would not throw any error and would return same 200 OK status code
New Behaviour:
If the handover fails because no agents were online, the endpoint will throw an error
Response status code: 409
Response body:
{ "error": "Handover failed! No agents online" }Plus, we're introducing a new setting where a admin can configure a custom message to be sent to the visitor, incase a handover attempt is failed