[FIX] typos & broken link in README.md#36
Conversation
|
Hey @Nabhag8848 thanks for the contribution ! Since this PR is a little old and we recently had some additions to the ReadMe, can you please verify if anything else needs fixing ? |
|
Yep! sure. |
|
Hey @samad-yar-khan , we will need one further change in Readme, looking for your verification.
While when we install the dependency using npm install it looks at package.json and what difference it make is:
As per official docs: https://docs.npmjs.com/cli/v9/commands/npm-ci Thus, we can avoid encountering the package-lock.json updated versions in contributors PR like PR #49 and ensure every contributor is on same dependency versions. |
Changes
About the PR: