Remove imagemagick dependency#17
Draft
sampaiodiego wants to merge 1 commit into
Draft
Conversation
Contributor
|
from my super limited testing I think this is fine. We actually removed imagemagick from snaps a while back with no issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing imagemagick is the most important change of this PR (as it might break rocket.chat - still need to test), but I'm also:
MAINTAINERinstruction as it has been deprecatedRUNcommand extracted from the official image (to make it easier to update and usingxzinstead ofbzip)(opened the PR as draft because still need to test rocket.chat without imagemagick)