Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

[CHORE] Remove codecov config#418

Merged
d-gubert merged 3 commits into
alphafrom
chore/remove-codecov
Jun 1, 2021
Merged

[CHORE] Remove codecov config#418
d-gubert merged 3 commits into
alphafrom
chore/remove-codecov

Conversation

@thassiov

@thassiov thassiov commented May 19, 2021

Copy link
Copy Markdown
Contributor

What? ⛵

Remove codecov config

Why? 🤔

As we are re-evaluating our testing methodology and static code analysis, we decided to remove codecov's bot until we reach a consensus about the tooling.

Links 🌎

PS 👀

@thassiov thassiov marked this pull request as ready for review May 19, 2021 13:41
@thassiov thassiov requested a review from a team May 19, 2021 13:41
shiqimei
shiqimei previously approved these changes May 19, 2021
@codecov

codecov Bot commented May 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #418 (d2a086a) into alpha (48aa55c) will decrease coverage by 0.59%.
The diff coverage is n/a.

❗ Current head d2a086a differs from pull request most recent head b7bd317. Consider uploading reports for the commit b7bd317 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #418      +/-   ##
==========================================
- Coverage   49.26%   48.67%   -0.60%     
==========================================
  Files         111      103       -8     
  Lines        3418     3244     -174     
  Branches      478      476       -2     
==========================================
- Hits         1684     1579     -105     
+ Misses       1734     1665      -69     
Impacted Files Coverage Δ
...ver/permissions/checkers/AppDetailChangesBridge.ts 0.00% <0.00%> (-50.00%) ⬇️
src/server/managers/index.ts
src/server/accessors/index.ts
src/server/bridges/index.ts
src/server/errors/index.ts
src/server/marketplace/license/index.ts
src/server/logging/index.ts
src/server/storage/index.ts
src/server/compiler/index.ts
src/server/permissions/checkers/AppRoomBridge.ts 24.00% <0.00%> (+9.71%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48aa55c...b7bd317. Read the comment docs.

@thassiov

Copy link
Copy Markdown
Contributor Author

@lolimay I'm going to dismiss your review as I didn't put the PR as a draft by mistake 😬 but I'll ask again for a review later. Thank you!

@thassiov thassiov dismissed shiqimei’s stale review May 19, 2021 13:54

pr is not done. should be a draft

@thassiov thassiov requested review from d-gubert and shiqimei May 26, 2021 12:53
Comment thread .circleci/config.yml
@d-gubert d-gubert merged commit 063b0d7 into alpha Jun 1, 2021
@d-gubert d-gubert deleted the chore/remove-codecov branch June 1, 2021 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants