[FIX] Update getValueById for properly getting value for BOOLEAN and STRING Setting

[Shailesh351]

Fixes #425

What? ⛵

• Updated ISettingRead getValueById
• Updated IServerSettingRead getValueById

Why?

Earlier Behaviour

public async getValueById(id: string): Promise<any> {
        const set = await this.settingBridge.getOneById(id, this.appId);

        if (typeof set === 'undefined') {
            throw new Error(`No Server Setting found, or it is unaccessible, by the id of "${id}".`);
        }

        return set.value || set.packageValue;
    }

The issue is with the BOOLEAN settings. When packageValue (default value) is set to true and value (current value) if false,
It returns true because of OR ||.

Similar issue when setting value is '' for STRING Setting.

Behaviour after this PR

Properly returns BOOLEAN and STRING setting

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #426 (e8fa629) into alpha (9502795) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            alpha     #426      +/-   ##
==========================================
- Coverage   49.26%   48.73%   -0.54%     
==========================================
  Files         110      102       -8     
  Lines        3410     3240     -170     
  Branches      478      476       -2     
==========================================
- Hits         1680     1579     -101     
+ Misses       1730     1661      -69     

Impacted Files	Coverage Δ
src/server/accessors/ServerSettingRead.ts	100.00% <100.00%> (ø)
src/server/accessors/SettingRead.ts	100.00% <100.00%> (ø)
...ver/permissions/checkers/AppDetailChangesBridge.ts	0.00% <0.00%> (-50.00%)	⬇️
src/server/logging/index.ts
src/server/managers/index.ts
src/server/storage/index.ts
src/server/compiler/index.ts
src/server/accessors/index.ts
src/server/bridges/index.ts
src/server/errors/index.ts
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9502795...e8fa629. Read the comment docs.

[d-gubert]

Thank you for your contribution! :D