This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[IMPROVE] Split app removal process#428
Merged
Merged
Conversation
shiqimei
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Splits the process of removing an app from the Apps-Engine in two parts: remove it from the DB and then remove the instantiated class from the set of apps in the manager
Why? 🤔
This allows us to make different calls in Rocket.Chat, calling the whole removal process when the user clicks the "Uninstall" button, but only removing the app instance from the local server memory when it receives a notification that an app has been uninstalled in the cluster
Links 🌎
PS 👀