Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

[NEW] Add runtime provider management and support VM2#512

Merged
AllanPazRibeiro merged 28 commits into
alphafrom
improvement/vm2-poc
Sep 22, 2022
Merged

[NEW] Add runtime provider management and support VM2#512
AllanPazRibeiro merged 28 commits into
alphafrom
improvement/vm2-poc

Conversation

@d-gubert

@d-gubert d-gubert commented Jun 6, 2022

Copy link
Copy Markdown
Member

What? ⛵

Add runtime provider management and support VM2

Why? 🤔

TBD

Links 🌎

PS 👀

@lgtm-com

lgtm-com Bot commented Jun 6, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 68c64f8 into 84841fd - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Jul 28, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 10ef2ae into ceb9cfc - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Jul 29, 2022

Copy link
Copy Markdown

This pull request introduces 3 alerts and fixes 2 when merging 1b75bf8 into ceb9cfc - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Jul 30, 2022

Copy link
Copy Markdown

This pull request introduces 5 alerts and fixes 2 when merging 836d43f into ceb9cfc - view on LGTM.com

new alerts:

  • 2 for Syntax error
  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 1, 2022

Copy link
Copy Markdown

This pull request introduces 3 alerts and fixes 2 when merging c1696b9 into ceb9cfc - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 1, 2022

Copy link
Copy Markdown

This pull request introduces 3 alerts and fixes 2 when merging aa1b32c into ceb9cfc - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 1, 2022

Copy link
Copy Markdown

This pull request introduces 3 alerts and fixes 2 when merging a097144 into ceb9cfc - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 4, 2022

Copy link
Copy Markdown

This pull request introduces 3 alerts and fixes 2 when merging ad4b7a8 into 515cfc2 - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 9, 2022

Copy link
Copy Markdown

This pull request introduces 3 alerts and fixes 2 when merging bcc52e9 into 515cfc2 - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 15, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 14b95b6 into 515cfc2 - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

* with previous Apps-Engine versions
*/
export function transformFallbackModuleForCustomRequire(moduleName: string): string {
return path.normalize(moduleName).replace(/\.\.?\//g, '').replace(/^\//, '') + '.ts';

Check failure

Code scanning / CodeQL

Incomplete multi-character sanitization

This string may still contain [../](1), which may cause a path injection vulnerability.
}

export function transformModuleForCustomRequire(moduleName: string): string {
return path.normalize(moduleName).replace(/\.\.?\//g, '').replace(/^\//, '') + '.js';

Check failure

Code scanning / CodeQL

Incomplete multi-character sanitization

This string may still contain [../](1), which may cause a path injection vulnerability.
@lgtm-com

lgtm-com Bot commented Aug 24, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 0daf864 into f1e8f1a - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Aug 24, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 137e816 into f1e8f1a - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Sep 14, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 46c721c into 5fdd30d - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@lgtm-com

lgtm-com Bot commented Sep 14, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging c0981ed into 5fdd30d - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@AllanPazRibeiro AllanPazRibeiro marked this pull request as ready for review September 14, 2022 18:21

@pierre-lehnen-rc pierre-lehnen-rc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed only the videoconf changes.

@lgtm-com

lgtm-com Bot commented Sep 21, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 62ce8c8 into 5fdd30d - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

Comment thread package.json Outdated
Comment thread src/definition/package.json Outdated
Comment thread package-lock.json Outdated
@lgtm-com

lgtm-com Bot commented Sep 22, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts and fixes 2 when merging 48a8228 into 5fdd30d - view on LGTM.com

new alerts:

  • 2 for Incomplete multi-character sanitization

fixed alerts:

  • 2 for Incomplete multi-character sanitization

@AllanPazRibeiro AllanPazRibeiro merged commit cc757c9 into alpha Sep 22, 2022
@AllanPazRibeiro AllanPazRibeiro deleted the improvement/vm2-poc branch September 22, 2022 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants