Skip to content

[NEW] Audio recorder cancel, persist, hold gestures and tooltip#2199

Closed
regalstreak wants to merge 29 commits into
RocketChat:developfrom
regalstreak:audio-recorder-cancel-gesture
Closed

[NEW] Audio recorder cancel, persist, hold gestures and tooltip#2199
regalstreak wants to merge 29 commits into
RocketChat:developfrom
regalstreak:audio-recorder-cancel-gesture

Conversation

@regalstreak

@regalstreak regalstreak commented Jun 18, 2020

Copy link
Copy Markdown
Contributor

* Refactor MessageBox to accommodate recording button even when recording
* Rename Recording.js -> RecordAudio.js as we could implement video recording in the future
@regalstreak regalstreak changed the title Audio Enhancements: Audio recorder cancel gesture Audio-Enhancements: Audio recorder cancel gesture Jun 18, 2020
@regalstreak regalstreak force-pushed the audio-recorder-cancel-gesture branch from ffcaf70 to 43d0dd3 Compare June 18, 2020 12:31
@regalstreak regalstreak force-pushed the audio-recorder-cancel-gesture branch from 43d0dd3 to a992c51 Compare June 25, 2020 10:57
@regalstreak regalstreak reopened this Jun 26, 2020
@regalstreak regalstreak changed the title Audio-Enhancements: Audio recorder cancel gesture Audio-Enhancements: Audio recorder cancel gesture, tooltip, hold Jun 28, 2020
@lgtm-com

lgtm-com Bot commented Jul 8, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging ef751a8 into 53cc823 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jul 11, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 2969ebf into 146babc - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@regalstreak regalstreak changed the title Audio-Enhancements: Audio recorder cancel gesture, tooltip, hold [NEW] Audio recorder cancel, persist, hold gestures and tooltip Jul 12, 2020

@djorkaeffalexandre djorkaeffalexandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should show the mic icon inner this blue bubble.
The slide to cancel message isn't appearing.

This animation looks weird and the button just disappear without any feedback after swipe up.

The keyboard is closing when I start to record on Android, and the bubble looks weird.

The cancel animation looks great. 😄

Comment thread app/containers/MessageBox/RecordAudio.js Outdated
Comment thread app/containers/MessageBox/styles.js Outdated
Comment thread app/containers/MessageBox/styles.js Outdated
Comment thread app/containers/MessageBox/styles.js Outdated
Comment thread app/containers/MessageBox/styles.js Outdated
Comment thread app/containers/MessageBox/RecordAudio.js Outdated
Comment thread app/containers/MessageBox/RecordAudio.js Outdated
Comment thread app/containers/MessageBox/styles.js Outdated
Comment thread app/containers/MessageBox/RecordAudio.js Outdated
Comment thread app/containers/MessageBox/RecordAudio.js Outdated
@regalstreak

Copy link
Copy Markdown
Contributor Author

@djorkaeffalexandre have a look

Screen Recording 2020-08-21 at 2 28 34 AM

@djorkaeffalexandre

Copy link
Copy Markdown
Contributor

@djorkaeffalexandre have a look

Screen Recording 2020-08-21 at 2 28 34 AM

Looks nice :)

@dcuti8

dcuti8 commented Oct 28, 2020

Copy link
Copy Markdown

I replace the File changed code, the function work on android but not work on ios...

@dcuti8

dcuti8 commented Oct 28, 2020

Copy link
Copy Markdown

I replace the File changed code, the function work on android but not work on ios...
ios just show like @djorkaeffalexandre
image

if i change change the isRecording to true in startRecordingAudio in can show the recordingContent but cannot record..
startRecordingAudio = async() => { logEvent(events.ROOM_AUDIO_RECORD); const { isRecording } = this.state; if (!this.isRecorderBusy && !isRecording) { this.isRecorderBusy = true; this.setState({ isRecordingPersisted: false, isRecording: true });

@dcuti8

dcuti8 commented Oct 29, 2020

Copy link
Copy Markdown

when I update the expo-av packege from 8.2.1 to 8.6.0, the function is work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants