Skip to content

[CHORE] Improve reply notification code (iOS)#2476

Closed
djorkaeffalexandre wants to merge 3 commits into
developfrom
chore.reply-notification
Closed

[CHORE] Improve reply notification code (iOS)#2476
djorkaeffalexandre wants to merge 3 commits into
developfrom
chore.reply-notification

Conversation

@djorkaeffalexandre

Copy link
Copy Markdown
Contributor

Proposed changes

Method swizzling is the process of changing the implementation of an existing selector.
Using method swizzling we can improve/change some native implementation that was done by some library, overriding methods.
Bringing the code to our main app, instead of use a patch, give us more maintainability, and turn the code more concisely; we can stop of duplicate some native codes at iOS side. :)
At some moment I'll try to move all the iOS land patch of the React Native core libraries to Method Swizzling.

A really good explanation about Method swizzling:
https://nshipster.com/method-swizzling/

Issue(s)

How to test or reproduce

Reply a notification using an iOS device.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Some code will be improved on #2463.

@djorkaeffalexandre

Copy link
Copy Markdown
Contributor Author

Since it's not a large change, we can do it in #2463 to prevent merge problems. :)

@djorkaeffalexandre djorkaeffalexandre deleted the chore.reply-notification branch December 2, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant