Skip to content

[FIX] Login and register via Google OAuth#3645

Closed
try-catch-stack wants to merge 3 commits into
RocketChat:developfrom
try-catch-stack:google-oauth
Closed

[FIX] Login and register via Google OAuth#3645
try-catch-stack wants to merge 3 commits into
RocketChat:developfrom
try-catch-stack:google-oauth

Conversation

@try-catch-stack

Copy link
Copy Markdown
Contributor

Proposed changes

Login or register using Google was not working and the user was redirected to the login page everytime trying to login via Google.

Issue(s)

Fixes #3644

How to test or reproduce

  1. Login or register via Google and you'll be redirected to he login screen again. (Tried and tested on the open community server)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@try-catch-stack

Copy link
Copy Markdown
Contributor Author

@diegolmello @GleidsonDaniel The redirect uri was causing the issue. I do not know the other redirect uri (if any) other than the base, registered on the google console.
Can you please take a look if we have some other redirect uri or this is fine as it does solves the issue.

@debdutdeb debdutdeb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegolmello the same happened with out openlms oauth couple days ago, can't find the thread sorry 🙈 best person to confirm this would be Marcelo.

@diegolmello

Copy link
Copy Markdown
Member

Planned to be reviewed this sprint.

@reinaldonetof

Copy link
Copy Markdown
Contributor

LGTM

@try-catch-stack

Copy link
Copy Markdown
Contributor Author

Solved by RocketChat/Rocket.Chat#24381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Google OAth not working on the android application

5 participants