[FIX] Login and register via Google OAuth#3645
Closed
try-catch-stack wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
@diegolmello @GleidsonDaniel The redirect uri was causing the issue. I do not know the other redirect uri (if any) other than the base, registered on the google console. |
debdutdeb
approved these changes
Jan 25, 2022
debdutdeb
left a comment
Member
There was a problem hiding this comment.
@diegolmello the same happened with out openlms oauth couple days ago, can't find the thread sorry 🙈 best person to confirm this would be Marcelo.
Member
|
Planned to be reviewed this sprint. |
Contributor
|
LGTM |
Contributor
Author
|
Solved by RocketChat/Rocket.Chat#24381 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Login or register using Google was not working and the user was redirected to the login page everytime trying to login via Google.
Issue(s)
Fixes #3644
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments