Skip to content

[NEW] Redesign ReactionsList and migrate to bottom sheet#4346

Merged
diegolmello merged 3 commits into
developfrom
new.reactions-list
Aug 3, 2022
Merged

[NEW] Redesign ReactionsList and migrate to bottom sheet#4346
diegolmello merged 3 commits into
developfrom
new.reactions-list

Conversation

@try-catch-stack

@try-catch-stack try-catch-stack commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

  • Redesigned ReactionsList component which was previously rendered as Reactions Modal and migrate it to bottom sheet.

Issue(s)

How to test or reproduce

  • Long press on reactions below a message and see if the reactions list work as expected.

Screenshots

Before After
reactions-list-before new reactions-list

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

diegolmello
diegolmello requested changes Jul 13, 2022
View reviewed changes
Comment thread app/containers/ActionSheet/ActionSheet.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
@try-catch-stack try-catch-stack force-pushed the new.reactions-list branch 2 times, most recently from db8ac1f to 8c2ea91 Compare July 16, 2022 16:39
dnlsilva
dnlsilva suggested changes Jul 20, 2022
View reviewed changes
Comment thread app/containers/ActionSheet/ActionSheet.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx Outdated
Comment thread app/containers/ReactionsList.tsx
Comment thread app/containers/ReactionsList.tsx Outdated
@diegolmello diegolmello merged commit a4f171a into develop Aug 3, 2022
@diegolmello diegolmello deleted the new.reactions-list branch August 3, 2022 16:32
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
@try-catch-stack @diegolmello
[NEW] Redesign reactions list (#4346)
28bb6a0
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@try-catch-stack
[NEW] Redesign reactions list (RocketChat#4346)
e6ef2cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello requested changes
+1 more reviewer
@dnlsilva dnlsilva dnlsilva requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@try-catch-stack @diegolmello @dnlsilva