Skip to content

Chore: Try Github Actions#4376

Merged
diegolmello merged 10 commits into
developfrom
github-actions-v2
Jul 29, 2022
Merged

Chore: Try Github Actions#4376
diegolmello merged 10 commits into
developfrom
github-actions-v2

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Add github actions workflows.
Some points:

  • It is not possible to follow the flow of circleCI after the tests can run the build manually or not.
  • In this case, the best flow would be to build manually, or add some trigger, such as tag, comment, approval or something like that. The problems with this approach are that if I need to do subsequent builds, what would it be like? Remove and add tags again? Do comments every time?

For test flow and lint works perfectly.
For our build flow maybe not.

PR for example:
dnlsilva#2

  • Just edit tags

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@dnlsilva dnlsilva changed the title add test Github Actions Jul 18, 2022
@dnlsilva dnlsilva marked this pull request as ready for review July 18, 2022 18:18
Comment thread .github/workflow-android-experimental.yml Outdated
Comment thread .github/workflow-ios-experimental.yml Outdated
@diegolmello diegolmello changed the title Github Actions Chore: Try Github Actions Jul 29, 2022
@diegolmello diegolmello merged commit 0e378c6 into develop Jul 29, 2022
@diegolmello diegolmello deleted the github-actions-v2 branch July 29, 2022 17:10
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants