Skip to content

[FIX] Markdown's ListItem not using the entered index#4388

Merged
dnlsilva merged 3 commits into
developfrom
fix-ordered-list
Aug 11, 2022
Merged

[FIX] Markdown's ListItem not using the entered index#4388
dnlsilva merged 3 commits into
developfrom
fix-ordered-list

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Use the correct number instead of index.
Improvement in the code in general.

Issue(s)

How to test or reproduce

  • Send a message like these to someone:
1. Test
1. Test
1. Test
  • Try servers lower than 5.0

Screenshots

Before:
Screen Shot 2022-07-25 at 15 06 17

After:
Screen Shot 2022-07-25 at 15 05 25

Web:
Screen Shot 2022-07-25 at 15 06 28

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2022-07-25.at.21.42.59.mov

Do you think is it possible to correct show the list from markdown/List.tsx exactly the same as OrderedList? Because it's showing a strange UI/UX, showing first ordered, later when is sent the message, turns to 1. 1. 1.

Screen Shot 2022-07-25 at 21 49 09

See how it's showing when some error occurred.

@dnlsilva

Copy link
Copy Markdown
Contributor Author

Screen.Recording.2022-07-25.at.21.42.59.mov
Do you think is it possible to correct show the list from markdown/List.tsx exactly the same as OrderedList? Because it's showing a strange UI/UX, showing first ordered, later when is sent the message, turns to 1. 1. 1.

Screen Shot 2022-07-25 at 21 49 09

See how it's showing when some error occurred.

This is a parse problem and as it will be replaced in a short time, besides being a temporary visual problem (1 second), it's not worth the effort to try to solve it.

@dnlsilva dnlsilva merged commit 6b8086a into develop Aug 11, 2022
@dnlsilva dnlsilva deleted the fix-ordered-list branch August 11, 2022 14:30
@sandrotanner

Copy link
Copy Markdown

Very cool, thanks a lot!

diegolmello pushed a commit that referenced this pull request Sep 12, 2022
* fix ordered list number

* update snapshot
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants