[IMPROVE] Add All tab in Reactions List#4409
Merged
Merged
Conversation
try-catch-stack
force-pushed
the
improve.reactions-list
branch
from
8e443cd to
40ff141
Compare
diegolmello
requested changes
Aug 10, 2022
try-catch-stack
force-pushed
the
improve.reactions-list
branch
from
59a91f0 to
1cbe416
Compare
try-catch-stack
force-pushed
the
improve.reactions-list
branch
2 times, most recently
from
c55b391 to
62ac5bb
Compare
diegolmello
force-pushed
the
improve.reactions-list
branch
from
1ac8e0d to
90aaca4
Compare
diegolmello
requested changes
Aug 25, 2022
diegolmello
left a comment
diegolmello
left a comment
Member
There was a problem hiding this comment.
I've fixed most bugs there.
There are two left:
- You're not respecting
useRealNameonalltab - The tab bar item calculation is not considering the actual size when in landscape, causing items to be very big
diegolmello
reviewed
Aug 25, 2022
diegolmello
force-pushed
the
improve.reactions-list
branch
from
4c2e024 to
fbd5cf4
Compare
diegolmello
requested changes
Sep 1, 2022
|
|
||
| const AllReactionsListItem = ({ item, baseUrl, getCustomEmoji, username }: IAllReactionsListItemProps) => { | ||
| const { colors } = useTheme(); | ||
| const useRealName = useSelector((state: IApplicationState) => state.settings.UI_Use_Real_Name); |
Member
There was a problem hiding this comment.
After I react, it doesn't apply use real name anymore
Simulator.Screen.Recording.-.iPhone.11.Pro.-.2022-09-01.at.12.54.43.mp4
Contributor
Author
There was a problem hiding this comment.
I could reproduce this on web app as well so probably an issue with the API.
diegolmello
approved these changes
Sep 29, 2022
diegolmello
added a commit
that referenced
this pull request
Oct 17, 2022
Co-authored-by: Diego Mello <diegolmello@gmail.com>
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Alltab in Reactions list where we can view all the reactions togetherIssue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
NATIVE-108