Skip to content

Chore: Hooks App/share#4417

Merged
reinaldonetof merged 5 commits into
developfrom
chore.hooks-app-share
Aug 18, 2022
Merged

Chore: Hooks App/share#4417
reinaldonetof merged 5 commits into
developfrom
chore.hooks-app-share

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Migrate the app/share.tsx from Class to Hooks. And cleaned some functions that aren't in use.

Issue(s)

How to test or reproduce

  • Open the gallery or folder from your smartphone
  • Share something by Rocket.Chat
  • Should open the Share Extension
  • Try logged in some server and without logged

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@lgtm-com

lgtm-com Bot commented Aug 8, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging ec089e5 into e38aedc - view on LGTM.com

fixed alerts:

  • 1 for Direct state mutation

Comment thread app/share.tsx Outdated
@lgtm-com

lgtm-com Bot commented Aug 10, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging b492d4f into 6df34a2 - view on LGTM.com

fixed alerts:

  • 1 for Direct state mutation

Comment thread app/share.tsx Outdated
@lgtm-com

lgtm-com Bot commented Aug 12, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 447b41a into c6e31df - view on LGTM.com

fixed alerts:

  • 1 for Direct state mutation

@lgtm-com

lgtm-com Bot commented Aug 18, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 7edd769 into 3ac10ee - view on LGTM.com

fixed alerts:

  • 1 for Direct state mutation

@reinaldonetof reinaldonetof merged commit f0ed501 into develop Aug 18, 2022
@reinaldonetof reinaldonetof deleted the chore.hooks-app-share branch August 18, 2022 23:25
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
* Chore: Hooks App/share

* getTheme to outside

* update types

Co-authored-by: Gleidson Daniel <gleidson10daniel@hotmail.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* Chore: Hooks App/share

* getTheme to outside

* update types

Co-authored-by: Gleidson Daniel <gleidson10daniel@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants