Chore: Migrate Touch to hooks#4422
Merged
Merged
Conversation
diegolmello
reviewed
Aug 9, 2022
Comment on lines
+95
to
+96
| // this is not the correct, but but we have a lot of "buttons" and a don't know what the font of truth | ||
| onPress={onReaction as () => void} |
Member
There was a problem hiding this comment.
I don't think it's a matter of source of truth.
RectButton uses
onPress?: (pointerInside: boolean) => void;while you're sending
({ emoji }: { emoji: TItem }) => voidSince Touch is a generic component, I'd override the type with Function.
Also we need to reevaluate this, since it's taken from a lib we're not using anymore.
reinaldonetof
approved these changes
Aug 16, 2022
diegolmello
pushed a commit
that referenced
this pull request
Sep 12, 2022
* migrate to hooks and fix types * fix import and remove theme prop * update tests * fix touch file name * wip * rename * change to touch * remove button and change to touch
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* migrate to hooks and fix types * fix import and remove theme prop * update tests * fix touch file name * wip * rename * change to touch * remove button and change to touch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Migrate Touch to hooks
Issue(s)
How to test or reproduce
To validate this change is basically to test some action sheet that has a button.
Screenshots
Types of changes
Checklist
Further comments