Skip to content

Chore: Migrate E2ESaveYourPasswordView to hooks#4432

Merged
dnlsilva merged 2 commits into
developfrom
save-your-password-view-hooks
Aug 17, 2022
Merged

Chore: Migrate E2ESaveYourPasswordView to hooks#4432
dnlsilva merged 2 commits into
developfrom
save-your-password-view-hooks

Conversation

@dnlsilva

Copy link
Copy Markdown
Contributor

Proposed changes

Migrate E2ESaveYourPasswordView to hooks

Issue(s)

How to test or reproduce

Test E2ESaveYourPasswordView

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@lgtm-com

lgtm-com Bot commented Aug 12, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 2b2e8d3 into c6e31df - view on LGTM.com

fixed alerts:

  • 1 for Direct state mutation

@lgtm-com

lgtm-com Bot commented Aug 17, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 7747ac2 into 585e5a0 - view on LGTM.com

fixed alerts:

  • 1 for Direct state mutation

@dnlsilva dnlsilva merged commit 28043a2 into develop Aug 17, 2022
@dnlsilva dnlsilva deleted the save-your-password-view-hooks branch August 17, 2022 13:51
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants