Chore: Create useDebounce hook#4470
Merged
Merged
Conversation
diegolmello
previously requested changes
Sep 8, 2022
| return _debounce; | ||
| } | ||
|
|
||
| export function useDebounce(func: Function, wait?: number, immediate?: boolean): (...args: any[]) => void { |
Member
There was a problem hiding this comment.
We discussed this internally, but we should consider using a lib instead of creating our own.
My main concern is related to the useCallback usage and here's why https://github.com/xnimorz/use-debounce/blob/8020962aed8038c065f9468fd7cf1d9a1751ce62/src/useDebouncedCallback.ts#L150
| return _debounce; | ||
| } | ||
|
|
||
| export function useDebounce(func: (...args: any) => any, wait?: number): (...args: any[]) => void { |
Contributor
There was a problem hiding this comment.
IMHO, I think we can export useDebounce from libs/hooks, WDYT?
Contributor
Author
There was a problem hiding this comment.
The question here is more to maintain debounce things on the same local.
If we change the useDebounce to hooks, we will have two files doing the same thing.
reinaldonetof
approved these changes
Sep 16, 2022
diegolmello
pushed a commit
that referenced
this pull request
Sep 28, 2022
* create useDebounce hook * fix types * apply useDebounce hook * migrate to use-debounce lib * remove useless useDebounce
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* create useDebounce hook * fix types * apply useDebounce hook * migrate to use-debounce lib * remove useless useDebounce
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* create useDebounce hook * fix types * apply useDebounce hook * migrate to use-debounce lib * remove useless useDebounce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Create useDebounce hook
Apply useDebounce hook where it is necessary
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments