Skip to content

[IMPROVE] Use Android 12 SplashScreen API#4479

Merged
diegolmello merged 6 commits into
developfrom
chore.update-splash
Oct 4, 2022
Merged

[IMPROVE] Use Android 12 SplashScreen API#4479
diegolmello merged 6 commits into
developfrom
chore.update-splash

Conversation

@diegolmello

@diegolmello diegolmello commented Aug 30, 2022

Copy link
Copy Markdown
Member

Proposed changes

Updates https://github.com/zoontek/react-native-bootsplash and adds support to Android 12 SplashScreen API.

Issue(s)

How to test or reproduce

  • We need to test it on 4 versions and on share extensions
    • Android Experimental
    • Android Official
    • iOS Experimental
    • iOS Official
  • Tested on
    • Samsung Galaxy s10e Android 12
    • Samsung Galaxy s21 Android 11
    • Samsung Galaxy s20 Android 10
    • Pixel 3a Android 9
    • Google Nexus 7 Android 6
    • iPhone 13 Pro Max
    • iPad (9th gen)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-111

@diegolmello diegolmello force-pushed the chore.update-splash branch 3 times, most recently from a006f50 to df2b136 Compare September 15, 2022 16:32
@diegolmello diegolmello requested a review from dnlsilva October 4, 2022 13:26
@diegolmello diegolmello merged commit 5828a04 into develop Oct 4, 2022
@diegolmello diegolmello deleted the chore.update-splash branch October 4, 2022 13:36
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants