Skip to content

[FIX] Big usernames during discussion creation bugs UI#4499

Merged
dnlsilva merged 4 commits into
developfrom
fix-multiselect
Sep 9, 2022
Merged

[FIX] Big usernames during discussion creation bugs UI#4499
dnlsilva merged 4 commits into
developfrom
fix-multiselect

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Fix item multiselect by correcting the spacing and styling of items and list.

Issue(s)

How to test or reproduce

When creating a discussion try to add a user whose name is too long.
Example: ursa-test

Screenshots

Before:
Screen Shot 2022-09-06 at 09 28 41
Screen Shot 2022-09-06 at 09 29 42

After:
Screen Shot 2022-09-06 at 08 54 34
Screen Shot 2022-09-06 at 09 04 32

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@dnlsilva dnlsilva merged commit 07f0618 into develop Sep 9, 2022
@dnlsilva dnlsilva deleted the fix-multiselect branch September 9, 2022 18:23
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
* fix multiselect itens style

* remove useless brackets

* remove scroll from the top of the list items
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* fix multiselect itens style

* remove useless brackets

* remove scroll from the top of the list items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants