Skip to content

[FIX] Remove the tmid parameter when it is empty#4500

Merged
dnlsilva merged 6 commits into
developfrom
fix-slash-commands
Sep 8, 2022
Merged

[FIX] Remove the tmid parameter when it is empty#4500
dnlsilva merged 6 commits into
developfrom
fix-slash-commands

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Remove the tmid parameter when it is empty

Tested on servers:
4.8
5.0
5.2

Closes #4491

Issue(s)

How to test or reproduce

Try to run any slash command

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Comment thread app/lib/services/restApi.ts
@dnlsilva dnlsilva changed the title [FIX] Add null to tmid parameter while calling commands.run api when tmid is undefined [FIX] Remove the tmid parameter when it is empty Sep 8, 2022
@dnlsilva dnlsilva merged commit f9f13e7 into develop Sep 8, 2022
@dnlsilva dnlsilva deleted the fix-slash-commands branch September 8, 2022 20:58
diegolmello pushed a commit that referenced this pull request Sep 12, 2022
* add custom fields after register

* remove tmid when it is null

* wip

* wip

* wip
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* add custom fields after register

* remove tmid when it is null

* wip

* wip

* wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slash commands do not work with server version 5.1.0

3 participants