Chore: Hooks app/views/UserNotificationPreferenceView#4502
Merged
Conversation
dnlsilva
suggested changes
Sep 12, 2022
| value ? OPTIONS[preference].find(option => option.value === value) : OPTIONS[preference][0] | ||
| ); | ||
|
|
||
| const getOptions = () => |
Contributor
There was a problem hiding this comment.
Does this really need to be a method?
Wouldn't a simple constant work?
Because from what I understand what changes is the preference, if it is fixed, there could even be a memo to avoid doing this every time you have a render.
Contributor
Author
There was a problem hiding this comment.
Yeap, will work if will be only a constant, however, every time the Picker re-render, will trigger a map, but this map we only need when opening the action sheet. So, instead of do a map every re-render, we are trigger the map only when we try to open the showActionSheet
dnlsilva
approved these changes
Sep 12, 2022
diegolmello
pushed a commit
that referenced
this pull request
Sep 28, 2022
* Chore: Hooks app/views/UserNotificationPreferenceView * added trycatch and userId Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* Chore: Hooks app/views/UserNotificationPreferenceView * added trycatch and userId Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* Chore: Hooks app/views/UserNotificationPreferenceView * added trycatch and userId Co-authored-by: Gleidson Daniel Silva <gleidson10daniel@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Chore: Hooks app/views/UserNotificationPreferenceView
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments