Skip to content

[FIX] Apply thicker border width and remove fixed height on TextInput#4503

Merged
reinaldonetof merged 4 commits into
developfrom
fix.border-widht-textinput
Sep 22, 2022
Merged

[FIX] Apply thicker border width and remove fixed height on TextInput#4503
reinaldonetof merged 4 commits into
developfrom
fix.border-widht-textinput

Conversation

@reinaldonetof

Copy link
Copy Markdown
Contributor

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Before

Screen Shot 2022-09-06 at 19 25 50

After

Screen Shot 2022-09-06 at 19 24 30

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 6, 2022

@diegolmello diegolmello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you review other places using FormTextInput/TextInput.
image

Also, can you add stories for FormTextInput?
Test icons, multiline, etc.

@reinaldonetof

Copy link
Copy Markdown
Contributor Author

Make sure you review other places using FormTextInput/TextInput.

Those TextInput and View are between 2 form text input to avoid that behavior looking like a login and password. So, both heights are set as hairline width to don't change the layout for Android devices.

@reinaldonetof reinaldonetof merged commit 214e1cc into develop Sep 22, 2022
@reinaldonetof reinaldonetof deleted the fix.border-widht-textinput branch September 22, 2022 21:16
diegolmello pushed a commit that referenced this pull request Sep 28, 2022
…#4503)

* [FIX] Apply thicker border width and remove fixed height on TextInput

* changed the last input border from hairline to 2

* update formtextinput storyshot test
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…RocketChat#4503)

* [FIX] Apply thicker border width and remove fixed height on TextInput

* changed the last input border from hairline to 2

* update formtextinput storyshot test
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…RocketChat#4503)

* [FIX] Apply thicker border width and remove fixed height on TextInput

* changed the last input border from hairline to 2

* update formtextinput storyshot test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants