Skip to content

Regression: Push notifications not working after update to Android 12#4532

Merged
diegolmello merged 3 commits into
developfrom
fix.notifications-android-12
Sep 22, 2022
Merged

Regression: Push notifications not working after update to Android 12#4532
diegolmello merged 3 commits into
developfrom
fix.notifications-android-12

Conversation

@diegolmello

@diegolmello diegolmello commented Sep 15, 2022

Copy link
Copy Markdown
Member

Proposed changes

https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability

Issue(s)

How to test or reproduce

  • Push notifications should be received properly
  • Reply and dismiss notifications should work

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello marked this pull request as ready for review September 15, 2022 19:29
@diegolmello diegolmello force-pushed the fix.notifications-android-12 branch from ec795bb to 9031f40 Compare September 22, 2022 20:39
@diegolmello diegolmello merged commit dec5c44 into develop Sep 22, 2022
@diegolmello diegolmello deleted the fix.notifications-android-12 branch September 22, 2022 20:39
diegolmello added a commit that referenced this pull request Sep 28, 2022
…#4532)

* Remove unnecessary method from custom push notification

* Use immutable

* Maybe
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…RocketChat#4532)

* Remove unnecessary method from custom push notification

* Use immutable

* Maybe
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…RocketChat#4532)

* Remove unnecessary method from custom push notification

* Use immutable

* Maybe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants