Regression: Poor performance in messages list on Android#4536
Merged
Conversation
diegolmello
force-pushed
the
fix.android-list
branch
from
59d1c3d to
78a7cb6
Compare
dnlsilva
approved these changes
Sep 19, 2022
diegolmello
force-pushed
the
fix.android-list
branch
from
78a7cb6 to
a129b93
Compare
This was referenced Sep 22, 2022
diegolmello
added a commit
that referenced
this pull request
Sep 28, 2022
* Create custom RefreshControl as a workaround * Remove unnecessary FlatList rngh change
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…4536) * Create custom RefreshControl as a workaround * Remove unnecessary FlatList rngh change
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…4536) * Create custom RefreshControl as a workaround * Remove unnecessary FlatList rngh change
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related to #3260
I was not able to use the exact same workaround after RN update, so I created a different one using RefreshControl.
Issue(s)
How to test or reproduce
Both iOS and Android messages list should work properly (pay attention to messages order)
Android should be a lot faster than on 4.30
Use the support chanel on open to measure performance, in others channels the performance is "acceptable".
Screenshots
"Profile HWUI rendering" > "On screen as bars" on Samsung S10e
Before
Screen_Recording_20220915_165648_RocketChat.Experimental.mp4
After
Screen_Recording_20220916_172254_RocketChat.Experimental.mp4
Types of changes
Checklist
Further comments