Skip to content

Chore: Hooks app/views/LanguageView#4537

Merged
reinaldonetof merged 3 commits into
developfrom
chore.hooks-languageview
Sep 22, 2022
Merged

Chore: Hooks app/views/LanguageView#4537
reinaldonetof merged 3 commits into
developfrom
chore.hooks-languageview

Conversation

@reinaldonetof

Copy link
Copy Markdown
Contributor

Proposed changes

Migration to Hooks app/views/LanguageView

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 16, 2022

@dnlsilva dnlsilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude the migration is correct, however I think that some things could be improved in the code taking advantage of this migration.
For example, you only use two user properties and still get the entire reducer object.
Another thing is when selecting a new language, if I select my current language it shouldn't change :)

I think it would be worthwhile to "correct" these two points by taking advantage of this PR.

@reinaldonetof reinaldonetof merged commit 9d69c10 into develop Sep 22, 2022
@reinaldonetof reinaldonetof deleted the chore.hooks-languageview branch September 22, 2022 21:40
diegolmello pushed a commit that referenced this pull request Sep 28, 2022
* Chore: Hooks app/views/LanguageView

* minor tweak app selector
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* Chore: Hooks app/views/LanguageView

* minor tweak app selector
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* Chore: Hooks app/views/LanguageView

* minor tweak app selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants