Chore: Hooks app/views/LanguageView#4537
Merged
Merged
Conversation
dnlsilva
suggested changes
Sep 19, 2022
dnlsilva
left a comment
Contributor
There was a problem hiding this comment.
Dude the migration is correct, however I think that some things could be improved in the code taking advantage of this migration.
For example, you only use two user properties and still get the entire reducer object.
Another thing is when selecting a new language, if I select my current language it shouldn't change :)
I think it would be worthwhile to "correct" these two points by taking advantage of this PR.
dnlsilva
approved these changes
Sep 19, 2022
diegolmello
pushed a commit
that referenced
this pull request
Sep 28, 2022
* Chore: Hooks app/views/LanguageView * minor tweak app selector
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* Chore: Hooks app/views/LanguageView * minor tweak app selector
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* Chore: Hooks app/views/LanguageView * minor tweak app selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Migration to Hooks app/views/LanguageView
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments