Skip to content

Chore: Migrate SettingsView to hooks#4542

Merged
dnlsilva merged 8 commits into
developfrom
migrate-settings-view-to-hooks
Sep 30, 2022
Merged

Chore: Migrate SettingsView to hooks#4542
dnlsilva merged 8 commits into
developfrom
migrate-settings-view-to-hooks

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Migrate SettingsView to hooks

Issue(s)

How to test or reproduce

Enter SettingsView and test the screen :) - There were no specific changes, because of this its only to validate if is working.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-46

Comment thread app/views/SettingsView/index.tsx Outdated
Comment thread app/views/SettingsView/index.tsx Outdated
dnlsilva and others added 4 commits September 29, 2022 09:31
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
@dnlsilva dnlsilva merged commit fe04faa into develop Sep 30, 2022
@dnlsilva dnlsilva deleted the migrate-settings-view-to-hooks branch September 30, 2022 14:50
diegolmello pushed a commit that referenced this pull request Oct 17, 2022
* migrate settings view to hooks

* temp - add non-null assertion

* fix options

* Update app/views/SettingsView/index.tsx

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>

* Update app/views/SettingsView/index.tsx

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>

* fix options

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* migrate settings view to hooks

* temp - add non-null assertion

* fix options

* Update app/views/SettingsView/index.tsx

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>

* Update app/views/SettingsView/index.tsx

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>

* fix options

Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants