Skip to content

[FIX] Decrease space between sections on Lists View#4543

Merged
diegolmello merged 5 commits into
developfrom
fix.decrease-section-list
Sep 23, 2022
Merged

[FIX] Decrease space between sections on Lists View#4543
diegolmello merged 5 commits into
developfrom
fix.decrease-section-list

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Decrease padding header of some views:

  • SelectServerView
  • AutoTranslateView
  • DefaultBrowserView
  • LanguageView
  • ReadReceiptView

Also, now the Design team requested some changes in this PR #4520 to change the margin from 8 to 16.

Issue(s)

How to test or reproduce

Screenshots

Before After
Screen Shot 2022-09-19 at 16 28 29 Screen Shot 2022-09-19 at 16 27 06
Screen Shot 2022-09-19 at 16 28 52 Screen Shot 2022-09-19 at 16 27 51

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 19, 2022
dnlsilva
dnlsilva approved these changes Sep 22, 2022
View reviewed changes

@dnlsilva dnlsilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in some places you're using padding and in others margin?
Why not use the same?

@diegolmello diegolmello force-pushed the fix.decrease-section-list branch from f362151 to f33a049 Compare September 23, 2022 20:24
@diegolmello diegolmello merged commit cbf9ae3 into develop Sep 23, 2022
@diegolmello diegolmello deleted the fix.decrease-section-list branch September 23, 2022 20:24
diegolmello added a commit that referenced this pull request Sep 28, 2022
@reinaldonetof @diegolmello
[FIX] Decrease space between sections on lists (#4543)
f6229ee 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @diegolmello
[FIX] Decrease space between sections on lists (RocketChat#4543)
40e2892 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @diegolmello
[FIX] Decrease space between sections on lists (RocketChat#4543)
912e9af 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes
+1 more reviewer
@dnlsilva dnlsilva dnlsilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinaldonetof @diegolmello @dnlsilva