Skip to content

[FIX] Cannot read property 'render' of undefined on markdown#4549

Merged
reinaldonetof merged 2 commits into
developfrom
fix.markdown-render
Sep 28, 2022
Merged

[FIX] Cannot read property 'render' of undefined on markdown#4549
reinaldonetof merged 2 commits into
developfrom
fix.markdown-render

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 21, 2022 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

I was not able to test the markdown easier, so to test, I commented the lines 332 ~ 347 and tested

Jira: TC-136

Issue(s)

How to test or reproduce

Screenshots

Before

Screen Shot 2022-09-21 at 16 24 57

Screen Shot 2022-09-21 at 16 26 55

After

Screen Shot 2022-09-21 at 16 27 32

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 21, 2022
@reinaldonetof reinaldonetof merged commit 43ebae9 into develop Sep 28, 2022
@reinaldonetof reinaldonetof deleted the fix.markdown-render branch September 28, 2022 20:06
diegolmello pushed a commit that referenced this pull request Oct 17, 2022
@reinaldonetof @diegolmello
[FIX] Cannot read property 'render' of undefined on markdown (#4549)
0974bbe
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
[FIX] Cannot read property 'render' of undefined on markdown (RocketC…
7d3fe06 
…hat#4549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dnlsilva dnlsilva dnlsilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reinaldonetof @dnlsilva