Skip to content

[FIX] Fix filenames and servers url when downloading audio files#4553

Merged
diegolmello merged 4 commits into
developfrom
fix-audio-files
Sep 23, 2022
Merged

[FIX] Fix filenames and servers url when downloading audio files#4553
diegolmello merged 4 commits into
developfrom
fix-audio-files

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

  • Adds support to servers with (forbidden printable ASCII characters) - example server.url:3000 (the colon)
  • Adds support to files with (forbidden printable ASCII characters) - example Audi:o.mp3 😀audio.mp3 (the colon and emoji)
  • Fix the download of files with same name.

Issue(s)

Closes #4548, #4534

How to test or reproduce

Try to download an audio file with a server terminating with colon - example localhost:3000
Send various audios with the same name - example record multilple audios on web

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: TC-107

@dnlsilva dnlsilva linked an issue Sep 22, 2022 that may be closed by this pull request
@dnlsilva dnlsilva changed the title [FIX] Fix filenames and servers url to download audio files [FIX] Fix filenames and servers url when downloading audio files Sep 23, 2022
@diegolmello diegolmello merged commit d1e2c3f into develop Sep 23, 2022
@diegolmello diegolmello deleted the fix-audio-files branch September 23, 2022 20:21
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio messages with non-unique filenames are broken in Android and iOS Android app can't play audio messages

2 participants