Skip to content

Regression: Default Browser View title#4556

Merged
diegolmello merged 1 commit into
developfrom
regression.default-browser-title
Sep 23, 2022
Merged

Regression: Default Browser View title#4556
diegolmello merged 1 commit into
developfrom
regression.default-browser-title

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

The previous title was wrong because a copy/paste and missed a more careful review on my part #4424
. Here is the fix for that regression.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 23, 2022
@diegolmello diegolmello force-pushed the regression.default-browser-title branch from f0b22e5 to 8c012d5 Compare September 23, 2022 20:21
@diegolmello diegolmello merged commit ee1b09d into develop Sep 23, 2022
@diegolmello diegolmello deleted the regression.default-browser-title branch September 23, 2022 20:22
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants