Skip to content

[FIX] Remove wrong logic on unread prop #4564

Merged
reinaldonetof merged 2 commits into
developfrom
fix-unread-badge
Oct 18, 2022
Merged

[FIX] Remove wrong logic on unread prop #4564
reinaldonetof merged 2 commits into
developfrom
fix-unread-badge

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Remove wrong logic on unread prop

Issue(s)

How to test or reproduce

Send a message on a server with read receipt enabled. (Mobile for example, open don't have this option enabled)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: TC-111

@dnlsilva dnlsilva changed the title [FIX] Remove wrong logic on unread prop [FIX] Remove wrong logic on unread prop [TC-111] Sep 26, 2022
@dnlsilva dnlsilva changed the title [FIX] Remove wrong logic on unread prop [TC-111] [FIX] Remove wrong logic on unread prop Sep 28, 2022
@reinaldonetof reinaldonetof merged commit 525f848 into develop Oct 18, 2022
@reinaldonetof reinaldonetof deleted the fix-unread-badge branch October 18, 2022 18:25
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: Reinaldo Neto <47038980+reinaldonetof@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants