[FIX] Cancelling when adding a server#4565
Merged
Merged
Conversation
dnlsilva
approved these changes
Sep 28, 2022
dnlsilva
approved these changes
Sep 29, 2022
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* TC-110 [FIX] Cancelling when adding a server * Removing the close button when connecting to a server
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* TC-110 [FIX] Cancelling when adding a server * Removing the close button when connecting to a server
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* TC-110 [FIX] Cancelling when adding a server * Removing the close button when connecting to a server
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* TC-110 [FIX] Cancelling when adding a server * Removing the close button when connecting to a server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Disable the close button while connecting and enable it again in case of an error
Issue(s)
How to test or reproduce
When opening the Servers List, on Room List View, the user has the option to add a new server.
If they click on it, they are redirected to a screen that is just like the "first screen of the app", on which the user types in the server they want and is moved on to continue to the login process.
This can also happen If the user taps on a server that's listed but has no user logged in.
However, this screen, unlike the "original first screen", can be closed by an "x" icon on the top left.
If this screen is closed before the app finishes "loading" the choice of server and redirects the user to the next screen, the app brings the user to the server they came from at the start of the process, but after a few seconds, redirects the user to the "actual" first screen of the app. One with no "x" to be closed. Effectively kicking the user out of logged servers and forcing the user to enter workspaces again.
It's fair to note that they are not "logged off". If they type a server that they were logged into, they don't need to go through the "log in" process again.
This is fixed by restarting the app.
Screenshots
Screen.Recording.2022-09-28.at.15.46.38.mov
Types of changes
Checklist
Further comments
Jira: TC-110