Skip to content

[FIX] Cancelling when adding a server#4565

Merged
reinaldonetof merged 3 commits into
developfrom
fix.cancelling-auto-login
Nov 1, 2022
Merged

[FIX] Cancelling when adding a server#4565
reinaldonetof merged 3 commits into
developfrom
fix.cancelling-auto-login

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Disable the close button while connecting and enable it again in case of an error

Issue(s)

How to test or reproduce

When opening the Servers List, on Room List View, the user has the option to add a new server.

If they click on it, they are redirected to a screen that is just like the "first screen of the app", on which the user types in the server they want and is moved on to continue to the login process.

This can also happen If the user taps on a server that's listed but has no user logged in.

However, this screen, unlike the "original first screen", can be closed by an "x" icon on the top left.

If this screen is closed before the app finishes "loading" the choice of server and redirects the user to the next screen, the app brings the user to the server they came from at the start of the process, but after a few seconds, redirects the user to the "actual" first screen of the app. One with no "x" to be closed. Effectively kicking the user out of logged servers and forcing the user to enter workspaces again.

It's fair to note that they are not "logged off". If they type a server that they were logged into, they don't need to go through the "log in" process again.

This is fixed by restarting the app.

Screenshots

Screen.Recording.2022-09-28.at.15.46.38.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: TC-110

@reinaldonetof reinaldonetof self-assigned this Sep 27, 2022
@reinaldonetof reinaldonetof merged commit 711cac5 into develop Nov 1, 2022
@reinaldonetof reinaldonetof deleted the fix.cancelling-auto-login branch November 1, 2022 17:09
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
* TC-110 [FIX] Cancelling when adding a server

* Removing the close button when connecting to a server
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
* TC-110 [FIX] Cancelling when adding a server

* Removing the close button when connecting to a server
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* TC-110 [FIX] Cancelling when adding a server

* Removing the close button when connecting to a server
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* TC-110 [FIX] Cancelling when adding a server

* Removing the close button when connecting to a server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants