Skip to content

Regression: Inconsistent style on TextInput on iOS and Android#4569

Merged
diegolmello merged 2 commits into
developfrom
regression.padding-form-textipunt
Sep 27, 2022
Merged

Regression: Inconsistent style on TextInput on iOS and Android#4569
diegolmello merged 2 commits into
developfrom
regression.padding-form-textipunt

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 27, 2022 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Jira TC-118

Issue(s)

How to test or reproduce

Screenshots

Before

Screen Shot 2022-09-27 at 15 06 16

After

Screen Shot 2022-09-27 at 15 05 41

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 27, 2022
@diegolmello diegolmello force-pushed the regression.padding-form-textipunt branch from 9ca138d to 2d2abe2 Compare September 27, 2022 18:17
@diegolmello diegolmello merged commit e48788c into develop Sep 27, 2022
@diegolmello diegolmello deleted the regression.padding-form-textipunt branch September 27, 2022 18:21
diegolmello pushed a commit that referenced this pull request Sep 28, 2022
@reinaldonetof @diegolmello
Regression: Inconsistent style on TextInput on iOS and Android (#4569)
a5fa159 
* Regression: Inconsistent style on TextInput on iOS and Android

* tweak to height
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
Regression: Inconsistent style on TextInput on iOS and Android (Rocke…
8d0842f 
…tChat#4569)

* Regression: Inconsistent style on TextInput on iOS and Android

* tweak to height
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @diegolmello
Regression: Inconsistent style on TextInput on iOS and Android (Rocke…
14b6570 
…tChat#4569)

* Regression: Inconsistent style on TextInput on iOS and Android

* tweak to height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

@reinaldonetof reinaldonetof

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reinaldonetof @diegolmello