Skip to content

[FIX] Touch/Face ID toggle does not enable automatically the first time#4576

Merged
reinaldonetof merged 3 commits into
developfrom
fix.enable-touchid-first-time
Oct 7, 2022
Merged

[FIX] Touch/Face ID toggle does not enable automatically the first time#4576
reinaldonetof merged 3 commits into
developfrom
fix.enable-touchid-first-time

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 28, 2022 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue(s)

Jira: TC-112

How to test or reproduce

  • Using a device that is possible to use touch id/ face id, go to Screen Lock View, enable unlock with passcode
  • Then, after save the passcode, the app will ask if you want to enable the face ID
  • Test the 2 behaviors:
  • If enable the face id/touch id test if you activate properly, if the switch will change to enable
  • Else if you don't want to activate the face id/touch id, the switch should keep as false

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Sep 28, 2022
dnlsilva
dnlsilva suggested changes Sep 29, 2022
View reviewed changes
Comment thread app/views/ScreenLockConfigView.tsx Outdated
@reinaldonetof reinaldonetof merged commit 300e5fc into develop Oct 7, 2022
@reinaldonetof reinaldonetof deleted the fix.enable-touchid-first-time branch October 7, 2022 15:34
diegolmello pushed a commit that referenced this pull request Oct 17, 2022
@reinaldonetof @diegolmello
[FIX] Touch/Face ID toggle does not enable automatically the first ti…
331a202 
…me (#4576)

* [FIX] Touch/Face ID toggle does not enable automatically the first time

* minor tweak no competition setState
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
[FIX] Touch/Face ID toggle does not enable automatically the first ti…
bb5be8e 
…me (RocketChat#4576)

* [FIX] Touch/Face ID toggle does not enable automatically the first time

* minor tweak no competition setState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dnlsilva dnlsilva dnlsilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reinaldonetof @dnlsilva