[FIX] Screen Lock's Password screen UI is broken on tablets#4583
Merged
Conversation
dnlsilva
suggested changes
Oct 5, 2022
dnlsilva
approved these changes
Oct 6, 2022
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* [FIX] Screen Lock's Password screen UI is broken on tablets * minor tweak and added comment * minor tweak * minor tweak * minor tweak
diegolmello
pushed a commit
that referenced
this pull request
Dec 2, 2022
* [FIX] Screen Lock's Password screen UI is broken on tablets * minor tweak and added comment * minor tweak * minor tweak * minor tweak
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…at#4583) * [FIX] Screen Lock's Password screen UI is broken on tablets * minor tweak and added comment * minor tweak * minor tweak * minor tweak
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…at#4583) * [FIX] Screen Lock's Password screen UI is broken on tablets * minor tweak and added comment * minor tweak * minor tweak * minor tweak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR was first found because there is a visual bug when opening the Passcode View on some tablets when is in the landscape as you can see in the first image. Also, during the PR I found the same visual bug for devices in general (2nd image in before). So we talked and found 2 approaches:
1 - for devices there aren't tablets we will lock the orientation of the PasscodeView to Portrait only
2 - for tablets we are setting a dinamic height for the buttons depending the orientation and the height of the device
Jira: TC-137
Issue(s)
How to test or reproduce
Screenshots
Android Tablet Nexus 7 (800 x 1280)
Iphone 11 Pro
Screen.Recording.2022-09-29.at.17.54.58.mov
Types of changes
Checklist
Further comments