Skip to content

[FIX] Screen Lock's Password screen UI is broken on tablets#4583

Merged
reinaldonetof merged 7 commits into
developfrom
fix.password-screen-landscape
Oct 18, 2022
Merged

[FIX] Screen Lock's Password screen UI is broken on tablets#4583
reinaldonetof merged 7 commits into
developfrom
fix.password-screen-landscape

Conversation

@reinaldonetof

@reinaldonetof reinaldonetof commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

This PR was first found because there is a visual bug when opening the Passcode View on some tablets when is in the landscape as you can see in the first image. Also, during the PR I found the same visual bug for devices in general (2nd image in before). So we talked and found 2 approaches:

1 - for devices there aren't tablets we will lock the orientation of the PasscodeView to Portrait only
2 - for tablets we are setting a dinamic height for the buttons depending the orientation and the height of the device

Jira: TC-137

Issue(s)

How to test or reproduce

Screenshots

Android Tablet Nexus 7 (800 x 1280)

Before After
image Screen Shot 2022-09-28 at 19 37 30
Screen Shot 2022-09-29 at 17 51 58 Screen Shot 2022-09-29 at 17 51 11

Iphone 11 Pro

Before
Screen Shot 2022-09-28 at 19 30 12
Screen.Recording.2022-09-29.at.17.54.58.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@dnlsilva dnlsilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid repeating the same thing in all styles create a constant with { height: heightButtonRow } and pass it as a parameter, it's even easier to change in the future.

@reinaldonetof reinaldonetof merged commit 761aef2 into develop Oct 18, 2022
@reinaldonetof reinaldonetof deleted the fix.password-screen-landscape branch October 18, 2022 19:26
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
* [FIX] Screen Lock's Password screen UI is broken on tablets

* minor tweak and added comment

* minor tweak

* minor tweak

* minor tweak
diegolmello pushed a commit that referenced this pull request Dec 2, 2022
* [FIX] Screen Lock's Password screen UI is broken on tablets

* minor tweak and added comment

* minor tweak

* minor tweak

* minor tweak
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…at#4583)

* [FIX] Screen Lock's Password screen UI is broken on tablets

* minor tweak and added comment

* minor tweak

* minor tweak

* minor tweak
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…at#4583)

* [FIX] Screen Lock's Password screen UI is broken on tablets

* minor tweak and added comment

* minor tweak

* minor tweak

* minor tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants