Skip to content

Chore: Deprecate Dimensions#4597

Merged
diegolmello merged 1 commit into
developfrom
chore.deprecate-dimensions
Oct 21, 2022
Merged

Chore: Deprecate Dimensions#4597
diegolmello merged 1 commit into
developfrom
chore.deprecate-dimensions

Conversation

@diegolmello

@diegolmello diegolmello commented Oct 7, 2022

Copy link
Copy Markdown
Member

Proposed changes

We’ve been using our own Dimensions context on the root of the app.

Instead, we need to migrate to RN’s useWindowDimensions moving the whole logic to a self contained hook and decreasing complexity on app/index and app/share.

It’s going to take some time until we can finish this, because some components aren’t using hooks yet and they rely on our current logic, so let’s start using useWindowDimensions in baby steps.

On this PR, we're deprecating everything related to the current implementation.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-117

@diegolmello diegolmello force-pushed the chore.deprecate-dimensions branch from a1a460d to bf1a57e Compare October 21, 2022 18:28
@diegolmello diegolmello merged commit 1aef030 into develop Oct 21, 2022
@diegolmello diegolmello deleted the chore.deprecate-dimensions branch October 21, 2022 18:29
diegolmello added a commit that referenced this pull request Dec 2, 2022
diegolmello added a commit that referenced this pull request Dec 2, 2022
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants