Chore: Deprecate Dimensions#4597
Merged
Merged
Conversation
reinaldonetof
approved these changes
Oct 20, 2022
a1a460d to
bf1a57e
Compare
diegolmello
added a commit
that referenced
this pull request
Dec 2, 2022
diegolmello
added a commit
that referenced
this pull request
Dec 2, 2022
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
We’ve been using our own Dimensions context on the root of the app.
Instead, we need to migrate to RN’s useWindowDimensions moving the whole logic to a self contained hook and decreasing complexity on app/index and app/share.
It’s going to take some time until we can finish this, because some components aren’t using hooks yet and they rely on our current logic, so let’s start using useWindowDimensions in baby steps.
On this PR, we're deprecating everything related to the current implementation.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
NATIVE-117