[IMPROVE] Add ignore user to user profile#4600
Merged
Merged
Conversation
diegolmello
changed the title
diegolmello
requested changes
Oct 11, 2022
| if (this.fromRid) { | ||
| try { | ||
| const sub = await getSubscriptionByRoomId(this.fromRid); | ||
| this.subscriptionFrom = sub?.observe().subscribe(roomFrom => { |
Member
There was a problem hiding this comment.
We should remove this reactivity.
diegolmello
approved these changes
Oct 13, 2022
diegolmello
pushed a commit
that referenced
this pull request
Oct 17, 2022
* button ignore and pased the param * load room from database and check is is ignored * move handleIgnore to lib/method/helpers * Ignore and Unignore, also reactivity * block and unblock user * pass fromRid from actionView to InfoView too * remove console.log * unsubscribe subscriptionFrom * block and unblock user from dm * test to block user and ignore user * minor tweak * tweak data * minor tweak * add test before tapBack * refactor names
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* button ignore and pased the param * load room from database and check is is ignored * move handleIgnore to lib/method/helpers * Ignore and Unignore, also reactivity * block and unblock user * pass fromRid from actionView to InfoView too * remove console.log * unsubscribe subscriptionFrom * block and unblock user from dm * test to block user and ignore user * minor tweak * tweak data * minor tweak * add test before tapBack * refactor names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
We need to provide a simpler way to ignore users in a channel, also to block users too when accessing the Room Info View.
Add ignore button in user info, when clicking on the username on a message in a channel;
The icon will be the same as the block user in user profile;
Option will be exhibited in red;
It should be placed on the right of the message button;
If the user is already ignored; then the option of unignore should appear (same icon)
Issue(s)
How to test or reproduce
Screenshots
The video is reproducing the behavior when blocking a user from DM or ignoring a user from a channel.
Screen.Recording.2022-10-11.at.13.54.03.mov
Types of changes
Checklist
Further comments
Jira: TC-163